Decode rrule text from url #477
Open
+26
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents problems with circular imports. I still get 14 warnings about circular imports in rollup (regardless of using the main commonjs plugin or the alternate one), but at least the emitted code seems to work fine in both now.
Solving circular import hack
Fixes incorrect source paths in generated source maps.
Fix incorrect source paths in generated source maps (jkbrzt#303)
|
@jakubroztocil I fixed the merge conflicts by changing the base branch to |
|
@jakubroztocil Before your next release, can you merge this one? |
|
Pinging this |
|
@davidgoli Jakub referred me to you. Can you merge this? |
|
I'm beginning to wonder if there is an intersection between people who would want this to be merged and those who are able to at all … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #384
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing